Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-968

Empty default cover image filename handled incorrectly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Decision Required
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: Cover Art
    • Labels:
      None

      Description

      Code in /picard/coverart/image.py uses incorrect logic if caa_image_type_as_filename is set and cover_image_filename is not set:

              if (config.setting["caa_image_type_as_filename"] and
                  not self.is_front_image()):
                  filename = self.maintype
                  log.debug("Make cover filename from types: %r -> %r",
                            self.types, filename)
              else:
                  filename = config.setting["cover_image_filename"]
                  log.debug("Using default cover image filename %r", filename)
              filename = self._make_image_filename(filename, dirname, metadata)
      

      First if statement should probably read:

              if ((config.setting["caa_image_type_as_filename"] and
                  not self.is_front_image()) or
                  not config.setting["cover_image_filename"]):
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sophist Sophist
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Packages

                Version Package