ExportXMLWordPrintable

    • Type: Bug
    • Resolution: Invalid
    • Priority: Normal
    • None
    • Affects Version/s: 1.4
    • Component/s: Cover Art
    • None

      Code in /picard/coverart/image.py uses incorrect logic if caa_image_type_as_filename is set and cover_image_filename is not set:

              if (config.setting["caa_image_type_as_filename"] and
                  not self.is_front_image()):
                  filename = self.maintype
                  log.debug("Make cover filename from types: %r -> %r",
                            self.types, filename)
              else:
                  filename = config.setting["cover_image_filename"]
                  log.debug("Using default cover image filename %r", filename)
              filename = self._make_image_filename(filename, dirname, metadata)
      

      First if statement should probably read:

              if ((config.setting["caa_image_type_as_filename"] and
                  not self.is_front_image()) or
                  not config.setting["cover_image_filename"]):
      

            Assignee:
            Unassigned
            Reporter:
            Sophist
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package