Uploaded image for project: 'BookBrainz'
  1. BookBrainz
  2. BB-669

Some achievements appear to be broken

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None

      We have an achievements system (https://bookbrainz.org/editor/1245/achievements) which should unlock achievements according to certain milestones calculated on a user's edits.

      However it looks like some achievements are not working and are not being unlocked when they should.
      See this forum discussion for more details: https://community.metabrainz.org/t/elusive-worker-bee-create-work-achievement-badges/581775/19

      The achievement unlock system should be thoroughly tested and the code for it combed through to figure out why the achievements might not be unlocked.

      In that process, that old code should be rewritten using async/await instead of promises for legibility. We've been slowing doing the same across the codebase.

      The code in question can be found here: 
      https://github.com/metabrainz/bookbrainz-site/blob/master/src/server/helpers/achievement.js

            shubh Shubham
            mr_monkey Monkey
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package