Uploaded image for project: 'ListenBrainz'
  1. ListenBrainz
  2. LB-331

MessyBrainz should not consider case while generating msids

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None

      Because we consider case, stuff like " we get duplicates in LB, see LB-314

      > "track_name": "Ours to Give (Makhana Remix)"
> "track_name": "Ours to Give (Makhana remix)"

      > "release_name": "Hers Was As Thunder"
>"release_name": "Hers Was as Thunder",

      For now, this should include changes here:
      https://github.com/metabrainz/messybrainz-server/blob/e810aeb135b276fc91d46c44a56c4bc7b287b130/messybrainz/data.py#L21-L23
      https://github.com/metabrainz/messybrainz-server/blob/e810aeb135b276fc91d46c44a56c4bc7b287b130/messybrainz/data.py#L122-L123
      https://github.com/metabrainz/messybrainz-server/blob/e810aeb135b276fc91d46c44a56c4bc7b287b130/messybrainz/data.py#L147-L152

      An improvement to this code would be to create a helper function that does the json.dumps, lowercases the text, and computes the sha256

            iliekcomputers Param Singh
            iliekcomputers Param Singh
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package