Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-12840

Revert lumping of historic edits into reused names

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Edit search, Edit system
    • None

      Right now we are lumping together edit types for search based on their name (for example, we have 6 different edits named "Edit release", all of which are actually different (5 are historic edits which did one of the several things the current "edit release" edit does).

      This means our documentation looks stupid (MBS-7509 / https://musicbrainz.org/doc/Edit_Types), and there's no good way to search for a specific sort of these historic edits in the edit search (if for example we want to check them for errors). It also inevitably loses context when looking at the edit in the edit history.

      yvanzo proposed reverting the names changed in https://github.com/metabrainz/musicbrainz-server/commit/bdb556e5cde55e1a02affac4f08c98ae6e0d302c (although probably making sure they are marked "(historic)", and then using the already known edit_kind of the edits (add/edit/merge/remove/other) (MBS-12839) and the affected entity type to filter searches. As such, we would be able to say we want specifically "Change release group (historic)" edits (search by type), or that we want all edits for entity "release" that do an "edit" (which would be the equivalent of doing an "Edit release" type search now).

            Unassigned Unassigned
            reosarevok Nicolás Tamargo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package