Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-13223

Error when switching an existing artist-series relationship with dates to "founder"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Normal Normal
    • None
    • None
    • None
    • None

      Prior to STYLE-2189 I used a "part of" artist-series relationship to link the founder to its music competition in https://musicbrainz.org/edit/83173493

      Today I tried to switch to a "founder" artist-series relationship and got an internal server error.
      The problem is the start and end dates were kept. I had to remove them manually and uncheck the ended checkbox to do the edit without error in https://musicbrainz.org/edit/102532006

      Switching to "founder" artist-series relationship should automatically remove the dates
      OR
      the "founder" artist-series relationship should allow dates like the "founder" artist-place relationship and the "founder" artist-label relationship.

      Side note 1: the relationship now has an order!? "(order: 1)" which it didnt have before (or at least it wasn't displayed) and I can't remove it.
      Adding a founder normally doesnt give order (like in https://musicbrainz.org/edit/93927505 )

      Side note 2: for consistency artist-series and artist-place/artist-label relationships should have the same text, one is "founded / founded by" while the others are "founded / founders"

      Side note 3: in the relationship type selector "founder" artist-series relationship is still located under "event artists", it should be one level higher next to "part of".

      Internal server error on https://musicbrainz.org/artist/9dfc644b-b341-4ad9-adba-232c9ce76ace/edit
      Referrer: https://musicbrainz.org/artist/9dfc644b-b341-4ad9-adba-232c9ce76ace/edit

      Internal Server Error

      Oops, something went wrong!

      Error:

      The edit could not be created. Exception (MusicBrainz::Server::Exceptions::DatabaseError): P0001 DBD::Pg::st execute failed: ERROR: Attempt to add dates to a relationship type that does not support dates.
      CONTEXT: PL/pgSQL function check_has_dates() line 12 at RAISE [for Statement "INSERT INTO link (begin_date_month,end_date_month,begin_date_year,attribute_count,begin_date_day,end_date_year,ended,end_date_day,link_type) VALUES (?,?,?,?,?,?,?,?,?) RETURNING id" with ParamValues: 1=undef, 2=undef, 3='1971', 4='0', 5=undef, 6='2001', 7='1', 8=undef, 9='1004'] at lib/MusicBrainz/Server/Controller.pm line 83.

      at lib/Sql.pm line 348. at lib/MusicBrainz/Server/Model/MB.pm line 20
      MusicBrainz::Server::Model::MB::with_transaction(?, ?) called at lib/MusicBrainz/Server/Controller.pm line 192
      MusicBrainz::Server::Controller::edit_action(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) called at lib/MusicBrainz/Server/Controller/Role/EditRelationships.pm line 378
      MusicBrainz::Server::Controller::Artist::edit_action(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) called at lib/MusicBrainz/Server/Controller/Role/Edit.pm line 70
      MusicBrainz::Server::Controller::Role::Edit::_ANON_::SERIAL::199::edit(?, ?) called at lib/MusicBrainz/Server/Controller/Artist.pm line 751
      Catalyst::dispatch called at lib/MusicBrainz/Server.pm line 391
      MusicBrainz::Server::_ANON_ at lib/MusicBrainz/Server.pm line 356
      MusicBrainz::Server::with_translations(?, ?) called at lib/MusicBrainz/Server.pm line 392
      Class::MOP::Method::Wrapped::_ANON_ called at lib/MusicBrainz/Server.pm line 406
      Class::MOP::Method::Wrapped::_ANON_ called at lib/MusicBrainz/Server.pm line 494

      Time: 2023-08-09T06:22:03.879Z

      Host: d6fde66186c8

      Interface language: en

      URL: https://musicbrainz.org/artist/9dfc644b-b341-4ad9-adba-232c9ce76ace/edit

      Request data:

      {
      "body_parameters":

      { "edit-artist.rel.0.period.end_date.day": "", "edit-artist.url.3.period.begin_date.month": "", "edit-artist.url.3.period.begin_date.year": "", "edit-artist.name": "Pierre Firmin-Didot", "edit-artist.url.0.period.end_date.month": "", "edit-artist.rel.0.link_type_id": "1004", "edit-artist.url.0.text": "https://www.discogs.com/artist/9627751", "edit-artist.url.1.period.begin_date.month": "", "edit-artist.end_area.name": "Mainvilliers", "edit-artist.url.2.period.end_date.month": "", "edit-artist.url.0.relationship_id": "3446911", "edit-artist.url.0.period.end_date.day": "", "edit-artist.url.1.period.begin_date.day": "", "edit-artist.period.end_date.year": "2001", "edit-artist.url.3.text": "https://www.wikidata.org/wiki/Q76217320", "edit-artist.gender_id": "1", "edit-artist.isni_codes.0": "0000000006917259", "edit-artist.url.1.text": "https://catalogue.bnf.fr/ark:/12148/cb12605904j", "edit-artist.url.0.period.begin_date.month": "", "edit-artist.url.1.period.begin_date.year": "", "edit-artist.url.3.period.end_date.year": "", "edit-artist.rel.0.period.end_date.year": "2001", "edit-artist.url.3.period.end_date.month": "", "edit-artist.rel.0.period.ended": "1", "edit-artist.begin_area.gid": "70896ddf-1272-4f5d-a93b-07d6e400ce8b", "edit-artist.period.end_date.day": "5", "edit-artist.rel.0.period.begin_date.month": "", "edit-artist.rel.0.period.begin_date.day": "", "edit-artist.url.1.period.end_date.year": "", "edit-artist.begin_area_id": "34476", "edit-artist.url.2.period.end_date.day": "", "edit-artist.rel.0.relationship_id": "6122", "edit-artist.end_area_id": "34907", "edit-artist.url.2.period.begin_date.month": "", "edit-artist.url.0.period.ended": "0", "edit-artist.url.2.relationship_id": "3446909", "edit-artist.rel.0.period.end_date.month": "", "edit-artist.rel.0.period.begin_date.year": "1971", "edit-artist.url.0.period.begin_date.year": "", "edit-artist.url.1.period.end_date.month": "", "edit-artist.url.2.text": "http://viaf.org/viaf/17341986", "edit-artist.url.2.period.begin_date.year": "", "edit-artist.end_area.gid": "58af15c8-f56d-4c9f-b880-ca82c0c5783e", "edit-artist.area.name": "France", "edit-artist.url.0.period.begin_date.day": "", "edit-artist.rel.0.backward": "0", "edit-artist.url.3.period.end_date.day": "", "edit-artist.url.3.link_type_id": "352", "edit-artist.period.begin_date.month": "8", "edit-artist.url.2.period.end_date.year": "", "edit-artist.url.2.period.begin_date.day": "", "edit-artist.ipi_codes.0": "", "edit-artist.url.3.period.begin_date.day": "", "edit-artist.edit_note": "", "edit-artist.url.3.relationship_id": "4493633", "edit-artist.rel.0.target": "e7672d66-89ab-4378-bcb5-fe63609fc2c7", "edit-artist.type_id": "1", "edit-artist.url.1.relationship_id": "3446910", "edit-artist.url.2.period.ended": "0", "edit-artist.url.0.period.end_date.year": "", "edit-artist.url.1.link_type_id": "188", "edit-artist.rel.0.entity0_credit": "", "edit-artist.url.1.period.ended": "0", "edit-artist.area_id": "73", "edit-artist.sort_name": "Firmin-Didot, Pierre", "edit-artist.url.2.link_type_id": "310", "edit-artist.url.1.period.end_date.day": "", "edit-artist.url.0.link_type_id": "180", "edit-artist.begin_area.name": "Mesnil-sur-l'Estrée", "edit-artist.comment": "", "edit-artist.period.begin_date.day": "23", "edit-artist.period.begin_date.year": "1921", "edit-artist.area.gid": "08310658-51eb-3801-80de-5a0739207115", "edit-artist.rel.0.entity1_credit": "", "edit-artist.url.3.period.ended": "0", "edit-artist.period.end_date.month": "1" }

      ,
      "query_parameters": {}
      }

            Unassigned Unassigned
            mr_maxis MXS
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package