Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-3818

Make it possible to submit an edit note in Barcode submission and other web service calls

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Normal Normal
    • None
    • None
    • Web service
    • None

        [MBS-3818] Make it possible to submit an edit note in Barcode submission and other web service calls

        This will be resolved as part of MBS-211 work, but we will not be working on it before then. I'm closing this as a duplicate of MBS-211, and also linking MBS-211 as 'resolving' this.

        Oliver Charles added a comment - This will be resolved as part of MBS-211 work, but we will not be working on it before then. I'm closing this as a duplicate of MBS-211 , and also linking MBS-211 as 'resolving' this.

        Oliver Charles added a comment - In review http://codereview.musicbrainz.org/r/1814/

        Agreed to fix within 3 months in #musicbrianz-devel and through the scheduling game.

        Oliver Charles added a comment - Agreed to fix within 3 months in #musicbrianz-devel and through the scheduling game.

        Johannes W added a comment - - edited

        Exactly... the submission would be split in normal "Edit release" edits... this would also automatically solve MBS-3803.

        Johannes W added a comment - - edited Exactly... the submission would be split in normal "Edit release" edits... this would also automatically solve MBS-3803 .

        In fact, if we do this, then we don't need this special "edit barcodes" edit type at all, you just enter "edit release" edits.

        Oliver Charles added a comment - In fact, if we do this, then we don't need this special "edit barcodes" edit type at all, you just enter "edit release" edits.

        I'm definitely in favor of this, and it's how I first envisioned it working. I don't think this is too problematic for clients either, as we can make the edit note optional, so existing calls still work.

        Oliver Charles added a comment - I'm definitely in favor of this, and it's how I first envisioned it working. I don't think this is too problematic for clients either, as we can make the edit note optional, so existing calls still work.

        Valid point. Bulk edit submission from client (single request) is needed for efficiency; especially due to req-per-second limit. However edit notes need to be linked to an individual edit as manifested on the server, probably.

        My view is that the solution for this is that the server is changed to always create separate edits for each release (for a release-level edit submission like barcode association). We can decouple number-of-POSTs from number-of-edits-created and meet both goals. I mention this on the forum thread as well; these bulk edits are difficult to vote on. and that somehow the schema allows you to associate an edit note at the entity level. I can see the below is probably breaking the model by mixing in edit information with entities; but trying to get the idea across.

        <metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#">
            <release-list>
                <release id="047ea202-b98d-46ae-97f7-0180a20ee5cf">
                    <barcode>9780262560933</barcode>
                    <edit-detail>
                        <note>Sourced from release itself, label XXXX cat xxxx via Jaikoz 3.4.5</note>
                    </edit-detail>
                </release>
                <release id="047ea202-b98d-46ae-97f7-0180a20sdsdd">
                    <barcode>0000000000000</barcode>
                    <edit-detail>
                        <note>Sourced from release itself, label YYYY, cat yyyy via Jaikoz 3.4.5</note>
                    </edit-detail>
                </release>
            </release-list>
        </metadata>
        

        voiceinsideyou added a comment - Valid point. Bulk edit submission from client (single request) is needed for efficiency; especially due to req-per-second limit. However edit notes need to be linked to an individual edit as manifested on the server, probably. My view is that the solution for this is that the server is changed to always create separate edits for each release (for a release-level edit submission like barcode association). We can decouple number-of-POSTs from number-of-edits-created and meet both goals. I mention this on the forum thread as well; these bulk edits are difficult to vote on. and that somehow the schema allows you to associate an edit note at the entity level. I can see the below is probably breaking the model by mixing in edit information with entities; but trying to get the idea across. <metadata xmlns= "http://musicbrainz.org/ns/mmd-2.0#" > <release-list> <release id= "047ea202-b98d-46ae-97f7-0180a20ee5cf" > <barcode> 9780262560933 </barcode> <edit-detail> <note> Sourced from release itself, label XXXX cat xxxx via Jaikoz 3.4.5 </note> </edit-detail> </release> <release id= "047ea202-b98d-46ae-97f7-0180a20sdsdd" > <barcode> 0000000000000 </barcode> <edit-detail> <note> Sourced from release itself, label YYYY, cat yyyy via Jaikoz 3.4.5 </note> </edit-detail> </release> </release-list> </metadata>

        You want an edit note for each barcode? The edit is a problem atm because you can submit multiple barcodes in a single edit (http://tickets.musicbrainz.org/browse/MBS-803 already hinted at that being a problem, and I initially suggested one edit per release).

        So can someone clarify what this means?

        Oliver Charles added a comment - You want an edit note for each barcode? The edit is a problem atm because you can submit multiple barcodes in a single edit ( http://tickets.musicbrainz.org/browse/MBS-803 already hinted at that being a problem, and I initially suggested one edit per release). So can someone clarify what this means?

        Johannes W added a comment -

        Yes, exactly, thanks!

        Johannes W added a comment - Yes, exactly, thanks!

        Paul Taylor added a comment -

        per barcode you submit

        Paul Taylor added a comment - per barcode you submit

          acid2 Oliver Charles
          hrglgrmpf Johannes W
          Votes:
          2 Vote for this issue
          Watchers:
          2 Start watching this issue

            Created:
            Updated:
            Resolved:

              Version Package