Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-486

Add support for years BC

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Review Submitted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      It looks, from http://codereview.musicbrainz.org/r/508/diff/ , like someone tried this, using "100-xx-xx to -1-xx-xx" to represent BC years. However, while that does generate a "Caught exception in MusicBrainz::Server::Controller::Artist>edit "Date::Calc::PP::Delta_Days(): Date::Calc::Delta_Days(): not a valid date at /home/mbserver/musicbrainz/mb_server/script/../lib/MusicBrainz/Server/Form/Role/DatePeriod.pm line 24"" error, the bug fix described in that code review fixes the wrong thing.

      BC years are not properly expressed using negative year numbers, but rather by using positive integers. (eg: 100 years before 1 AD was not -100 AD, but rather 100 BC). We likely have very few artists/etc that would ever use BC years, but currently, if you try to set "100 to 1" as the years, you get a "The end date must occur on or after the begin date" error; the only real "fix" I can see which would make sense would be the addition of a "AD/BC" dropdown next to date fields, with AD as the default.

      Tested on http://test.musicbrainz.org/artist/e2c3124c-7e90-4708-ad8c-4f3559246922/edit

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              reosarevok Nicolás Tamargo
              Reporter:
              brianfreud Brian Schweitzer
              Votes:
              7 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:

                  Packages

                  Version Package