Uploaded image for project: 'MusicBrainz Server'
  1. MusicBrainz Server
  2. MBS-7545

Release editor creates empty URL edits if you just change the release name

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2014-05-26
    • None
    • Release editor
    • None

        [MBS-7545] Release editor creates empty URL edits if you just change the release name

        Ulrich Klauer added a comment -

        Fixed in https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/949/post-schema-change-hotfix-workaround-for/diff (together with the remove-dates-from-relationships issue).

        Ulrich Klauer added a comment - Fixed in https://bitbucket.org/metabrainz/musicbrainz-server/pull-request/949/post-schema-change-hotfix-workaround-for/diff (together with the remove-dates-from-relationships issue).

        Ulrich Klauer added a comment -

        Will try this.

        Ulrich Klauer added a comment - Will try this.

        Michael Wiencek added a comment -

        Or the code can be moved up to the Edit class to have it normalize {} to

        { year => undef, month => undef, day => undef }

        for both places.

        Michael Wiencek added a comment - Or the code can be moved up to the Edit class to have it normalize {} to { year => undef, month => undef, day => undef } for both places.

        Michael Wiencek added a comment -

        It's a similar issue, but the release editor uses WS::js::Edit, not Controller::EditRelationships, so I have to copy the fix there too.

        Michael Wiencek added a comment - It's a similar issue, but the release editor uses WS::js::Edit, not Controller::EditRelationships, so I have to copy the fix there too.

        Ulrich Klauer added a comment -

        Ah, actually no, it won't fix this as-is (but can easily be changed to include this).

        Ulrich Klauer added a comment - Ah, actually no, it won't fix this as-is (but can easily be changed to include this).

        Ulrich Klauer added a comment -

        This is the date issue, should be fixed by my pending PR.

        "new":{"end_date":{},"begin_date":{}},
"old":{"end_date":{"month":null,"day":null,"year":null},"begin_date":{"month":null,"day":null,"year":null}}

        Ulrich Klauer added a comment - This is the date issue, should be fixed by my pending PR. "new":{"end_date":{},"begin_date":{}}, "old":{"end_date":{"month":null,"day":null,"year":null},"begin_date":{"month":null,"day":null,"year":null}}

          chirlu Ulrich Klauer
          bitmap Michael Wiencek
          Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

            Created:
            Updated:
            Resolved:

              Version Package
              2014-05-26