Guess case should highlight changes made, particularly for tracklists. Ideally this would be on a character by character basis, but even whole-field like search→replace in mb. SUPER MIND CONTROL Ⅱ X TURBO userscript would be useful. Presumably there are some cases where characters are removed and not replaced, maybe highlighting either side would work here.

          [MBS-8217] Guess case should highlight changes

          That seems sensible to me

          Nicolás Tamargo added a comment - That seems sensible to me

          derat added a comment -

          Thanks, I've uploaded https://github.com/metabrainz/musicbrainz-server/pull/3331 to highlight updated names in the tracklist editor. I don't think that highlighting is needed anywhere else, since the button is only updating a single input that's right next to it (but let me know if you disagree).

          derat added a comment - Thanks, I've uploaded https://github.com/metabrainz/musicbrainz-server/pull/3331 to highlight updated names in the tracklist editor. I don't think that highlighting is needed anywhere else, since the button is only updating a single input that's right next to it (but let me know if you disagree).

          Highlighting the entire field after changing is indeed useful for stuff like releases with 60+ tracks where the preview doesn't fit on screen (and it's also not sensible to go track by track). This would mean I can guess case, then review only what has actually changed.

          Nicolás Tamargo added a comment - Highlighting the entire field after changing is indeed useful for stuff like releases with 60+ tracks where the preview doesn't fit on screen (and it's also not sensible to go track by track). This would mean I can guess case, then review only what has actually changed.

          Aerozol added a comment -

          Agreed that derat's (amazing!) fix doesn't solve this ticket (I think I mentioned that on the PR as well), but it's no big deal, we can reopen it.

          Yes, guess punctuation highlights the entire field after changes have been done.

          Aerozol added a comment - Agreed that derat's (amazing!) fix doesn't solve this ticket (I think I mentioned that on the PR as well), but it's no big deal, we can reopen it. Yes, guess punctuation highlights the entire field after changes have been done.

          derat added a comment - - edited

          Apologies if it would've been better to create a new ticket about displaying previews. (I have to admit that I sometimes try to minimize my interactions with Jira...)

          I don't think that there's any non-incredibly-hacky/fragile way to highlight individual changed characters in an <input type="text">. I don't have a userscript manager installed, but from looking at https://github.com/kellnerd/musicbrainz-scripts/blob/main/dist/guessUnicodePunctuation.user.js, I believe that it highlights entire fields after they've been changed – is that right, aerozol?

          From my first morning of using previews on the beta server, I'm doubtful that I'd get much additional value from highlighting fields after they've been modified, but I tend to click the per-track "Aa" buttons rather than the "Guess case" buttons for the entire medium or release since there are usually some track titles that would be incorrectly changed by the latter.

          If highlighting changed fields (just in the tracklist editor?) still seems useful to someone, I can look into adding that – I think it'd probably just be a matter of making the various case-guessing code add a new CSS class to fields that it changes and then removing that if/when they're manually changed later. I'm a bit worried it could be confusing from a UX perspective if the fields are being highlighted both on hover and after click. I'm not sure if using different highlight colors would make that better or worse.

          derat added a comment - - edited Apologies if it would've been better to create a new ticket about displaying previews. (I have to admit that I sometimes try to minimize my interactions with Jira...) I don't think that there's any non-incredibly-hacky/fragile way to highlight individual changed characters in an <input type="text"> . I don't have a userscript manager installed, but from looking at https://github.com/kellnerd/musicbrainz-scripts/blob/main/dist/guessUnicodePunctuation.user.js , I believe that it highlights entire fields after they've been changed – is that right, aerozol ? From my first morning of using previews on the beta server, I'm doubtful that I'd get much additional value from highlighting fields after they've been modified, but I tend to click the per-track "Aa" buttons rather than the "Guess case" buttons for the entire medium or release since there are usually some track titles that would be incorrectly changed by the latter. If highlighting changed fields (just in the tracklist editor?) still seems useful to someone, I can look into adding that – I think it'd probably just be a matter of making the various case-guessing code add a new CSS class to fields that it changes and then removing that if/when they're manually changed later. I'm a bit worried it could be confusing from a UX perspective if the fields are being highlighted both on hover and after click. I'm not sure if using different highlight colors would make that better or worse.

          Freso added a comment -

          FWIW, derat’s changes seem great, but they don’t address this ticket. derat’s changes allows you to preview the changes being made, but doesn’t highlight what’s been changed after the changes have been made, so pushing that(/those) PR(s) to production shouldn’t mark this ticket as Closed/Fixed.

          Freso added a comment - FWIW, derat’s changes seem great, but they don’t address this ticket. derat’s changes allows you to preview the changes being made, but doesn’t highlight what’s been changed after the changes have been made, so pushing that(/those) PR(s) to production shouldn’t mark this ticket as Closed/Fixed.

          Michael Wiencek added a comment - - edited

          The text drag fix from derat (https://github.com/metabrainz/musicbrainz-server/pull/3330) has been deployed to beta.

          Michael Wiencek added a comment - - edited The text drag fix from derat ( https://github.com/metabrainz/musicbrainz-server/pull/3330 ) has been deployed to beta.

          derat added a comment -

          Thanks for the quick report, chaban. I think that this can be fixed by just not showing the preview if a mouse button is held. I'll upload a change soon to do that.

          derat added a comment - Thanks for the quick report, chaban . I think that this can be fixed by just not showing the preview if a mouse button is held. I'll upload a change soon to do that.

          chaban added a comment -

          The hover function interferes with text selection. For example, on the standalone recording creation page the guess case button is right next to the title field. When the input text overflows and I wanted to select a portion of it until the end by drag-select every time the mouse pointer passes the button the selection is canceled.

          chaban added a comment - The hover function interferes with text selection. For example, on the standalone recording creation page the guess case button is right next to the title field. When the input text overflows and I wanted to select a portion of it until the end by drag-select every time the mouse pointer passes the button the selection is canceled.

          Aerozol added a comment -

          I think hover might not totally close this specific ticket as Tom Crocker envisaged it , but is an invaluable improvement nonetheless!

          Aerozol added a comment - I think hover might not totally close this specific ticket as Tom Crocker envisaged it , but is an invaluable improvement nonetheless!

            derat derat
            tommycrock Tom Crocker
            Votes:
            8 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2024-07-22