Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1325

Allow disabling new version update checking for packagers

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • None
    • User Interface
    • All

      PICARD-1045 adds the ability to automatically and manually check for program updates, along with associated configuration settings. Picard release packagers should be able to completely hide this functionality and configuration settings from the user for the packages they produce.

      The trigger mechanism for disabling the appropriate portions of the code needs to be determined. Some of the possible methods include:

      • Include a specified file (e.g.: PACKAGER.txt) in the application root directory, and have Picard check for the existence of the file.
      • Have the packager append a specified line of code to one of the Picard source files (e.g.: picard/__init__.py or picard/const/__init__.py) with the setting. (Not recommended because packagers would have to modify the Picard code.)
      • Add a new ini-type file (e.g.: picard-runtime.ini in the application root directory) to allow setting of this and possible future runtime options.

      The trigger mechanism needs to determined by the Picard development team after considering input from the people who package Picard for distribution.

          [PICARD-1325] Allow disabling new version update checking for packagers

          Philipp Wolfer added a comment -

          I set the fix version to 2.1.0 because I think we really should include this issue when releasing a version with update checking.

          Philipp Wolfer added a comment - I set the fix version to 2.1.0 because I think we really should include this issue when releasing a version with update checking.

          Philipp Wolfer added a comment -

          I looked into the code, we have left-over code for this already in Picard We can re-enable this and get it running.

          This was originally added at https://github.com/metabrainz/picard/commit/f19ca412f4de3e7df92d5f09781ea250c214bc87 , but later removed again.

          So what we still have:

          1. Using the --disable-autoupdate flag with "setup.py build" or "setup.py install", e.g. "python setup.py build --disable-autoupdate "
          2. The flag gets set in the call to picard.tagger.main
          3. The Tagger object has an attrubute _tagger

          What I would suggest doing is renaming the attribute in Tagger to something public (e.g. 'autoupdate_enabled') and check this at the necessary places of the existing update code (to disable the update checking and the UI for it if autoupdate_enabled = False)

          Philipp Wolfer added a comment - I looked into the code, we have left-over code for this already in Picard We can re-enable this and get it running. This was originally added at https://github.com/metabrainz/picard/commit/f19ca412f4de3e7df92d5f09781ea250c214bc87 , but later removed again. So what we still have: 1. Using the --disable-autoupdate flag with "setup.py build" or "setup.py install", e.g. "python setup.py build --disable-autoupdate " 2. The flag gets set in the call to picard.tagger.main 3. The Tagger object has an attrubute _tagger What I would suggest doing is renaming the attribute in Tagger to something public (e.g. 'autoupdate_enabled') and check this at the necessary places of the existing update code (to disable the update checking and the UI for it if autoupdate_enabled = False)

            Unassigned Unassigned
            rdswift Bob Swift
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1