-
Improvement
-
Resolution: Fixed
-
Normal
-
2.13
-
None
When building Picard with a PEP 517 compatible build system, e.g. when using python -m build, it is currently not possible to pass custom build parameters like --disable-autoupdate.
As distributions are switching the Python packaging to PEP 517 instead of invoking setup.py manually this breaks disabling the autoupdate in distribution packages.
Theoretically something like this should be possible:
python -m build --wheel -C--disable-autoupdate
Picard is using setuptools, and passing arbitrary configuration parameters is not supported there currently, see https://github.com/pypa/setuptools/issues/2491
One solution is to workaround with a custom build backend like it was done in https://github.com/capnproto/pycapnp/pull/328
Or there could be some other mechanism, like e.g. environment variable.
See discussion in https://community.metabrainz.org/t/how-to-invoke-disable-autoupdate-in-rpm-spec/722389/
- has related issue
-
-
- Open
-
-
-
- Closed
-
[PICARD-3003] Allow setting disable-autoupdate on build with PEP 517 build system
The following is a workaround for RPM spec files, which avoids the need of creating a patch.
%define setup setup.py %define autoupdate_on 'disable-autoupdate', None %define autoupdate_off 'disable-autoupdate', True %define selfauto_on self.disable_autoupdate = None %define selfauto_off self.disable_autoupdate = True
%build sed -r -i -e "s|%{autoupdate_on}|%{autoupdate_off}|g" \ -e "s|%{selfauto_on}|%{selfauto_off}|g" \ %{setup} %pyproject_wheel
Thanks for creating this outsidecontext.
I've consulted with the Fedora Python folks and no one has been able to get this to function. So, in the meantime, I've been patching setup.py.
See code changes in pull request #2592 submitted by phw.