Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1431

Some ID3 frames gets deleted even if the corresponding tags are shown as unchanged

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.1
    • 2.0.4
    • Tags & Metadata
    • None

      Some ID3 frames gets removed from files on saving if they are present in the original file but the corresponding tags have no value in new metadata. This affects the people related frames TIPL, TMCL and IPLS and the TCMP compilation flag.

      The behavior is confusing because the UI shows them as unchanged, but after saving these tags are gone.

          [PICARD-1431] Some ID3 frames gets deleted even if the corresponding tags are shown as unchanged

          Philipp Wolfer added a comment -

          The people frames will be solved by the fix for PICARD-1219.

          The TCMP (compilation) flag is a bit different. I think the current logic is that this flag will be removed if not present in the metadata, since there is no point setting this tag unless it explicitly is a compilation. That means this tag only ever gets set explicitly for compilations. Would it be kept it would not be removed if files originally tagged as compilation get tagged against an album.

          But the current behavior is problematic:

          1. It is only implemented this way in ID3
          2. The UI does not tell this

          Maybe a better approach is to remove the special case and explicitly mark the tag as deleted if it does not apply. That way all tagging formats behave the same and the UI will show the delete action getting applied.

          Philipp Wolfer added a comment - The people frames will be solved by the fix for PICARD-1219 . The TCMP (compilation) flag is a bit different. I think the current logic is that this flag will be removed if not present in the metadata, since there is no point setting this tag unless it explicitly is a compilation. That means this tag only ever gets set explicitly for compilations. Would it be kept it would not be removed if files originally tagged as compilation get tagged against an album. But the current behavior is problematic: It is only implemented this way in ID3 The UI does not tell this Maybe a better approach is to remove the special case and explicitly mark the tag as deleted if it does not apply. That way all tagging formats behave the same and the UI will show the delete action getting applied.

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.1