Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-157

"Translate artist names to this locale where possible" also translates ones already in the correct locale

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.7.0b1
    • None
    • Tags & Metadata
    • None

      When the option "Translate artist names to this locale where possible" is checked, it will also "translate" artists already in that locale. Effectively it ends up doing the same thing as "Standardize artist names". Example artist: http://musicbrainz.org/artist/3d4198c9-dc74-4eeb-ab90-68cc2d45b287/aliases — any release credited to "Jim Dooley" will be "translated" to "James Dooley".

      This may have been introduced in the fix to bug PICARD-1

          [PICARD-157] "Translate artist names to this locale where possible" also translates ones already in the correct locale

          With PICARD-2277 we now allow selection of scripts to ignore for translation. I think this also fixes this issue.

          Philipp Wolfer added a comment - With PICARD-2277 we now allow selection of scripts to ignore for translation. I think this also fixes this issue.

          GitHub Bot added a comment -

          See code changes in pull request #1885 submitted by vladkar.

          GitHub Bot added a comment - See code changes in pull request #1885 submitted by vladkar .

          The problem here for Picard is that it does not know what locale the artist name is in, so enabling the translation will always attempt using a matching locale. I agree that the best fix for this having a proper alias with locale even for the default name in the database.

          Philipp Wolfer added a comment - The problem here for Picard is that it does not know what locale the artist name is in, so enabling the translation will always attempt using a matching locale. I agree that the best fix for this having a proper alias with locale even for the default name in the database.

          Yeah - that'd need to be implemented on MBS side and enforced in the database to be an effective solution, I guess. Do you know if there any MBS tickets that deal with this?

          voiceinsideyou added a comment - Yeah - that'd need to be implemented on MBS side and enforced in the database to be an effective solution, I guess. Do you know if there any MBS tickets that deal with this?

          Alex Mauer added a comment -

          Bitmap commented in IRC that one way for this to work would be to standardize on always having an alias which matches the artist name and get the "native" locale from that one. Since my understanding is that ultimately we would like to move the "main" artist name to just pull from the aliases list itself, that would make sense to do anyway.

          Alex Mauer added a comment - Bitmap commented in IRC that one way for this to work would be to standardize on always having an alias which matches the artist name and get the "native" locale from that one. Since my understanding is that ultimately we would like to move the "main" artist name to just pull from the aliases list itself, that would make sense to do anyway.

          It doesn't have anything to do with the fix to PICARD-1 - all that fix did was re-enable the function which was disabled for album artists in some work to clean up the confusing use of albumartist and artist inside metadata (thus a regression from earlier stuff). That function and its fix predated the locale-aware implementation - all it handled was "translation" into latin names via the sort name.

          In any case, I think there might be another ticket for this somewhere as I've been aware of it for some time. It's really not clear how this could possibly work inside Picard; I just figured the locale should not be set inside MB for aliases which are of the same locale as the artist. Without there being a locale set on the artist entity that it could compare; there is no way for Picard to know what to do, as far as I can see.

          voiceinsideyou added a comment - It doesn't have anything to do with the fix to PICARD-1 - all that fix did was re-enable the function which was disabled for album artists in some work to clean up the confusing use of albumartist and artist inside metadata (thus a regression from earlier stuff). That function and its fix predated the locale-aware implementation - all it handled was "translation" into latin names via the sort name. In any case, I think there might be another ticket for this somewhere as I've been aware of it for some time. It's really not clear how this could possibly work inside Picard; I just figured the locale should not be set inside MB for aliases which are of the same locale as the artist. Without there being a locale set on the artist entity that it could compare; there is no way for Picard to know what to do, as far as I can see.

            Unassigned Unassigned
            hawke Alex Mauer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Version Package
                2.7.0b1