Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-1909

No refresh of metadata on "Use Original Value" or remove tags

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 2.4.2
    • 2.4, 2.4.1
    • User Interface
    • None
    • Windows 10
      (v2.4 installed, v2.4.1 portable

      If tags in local files have a different value then on the MusicBrainz server (or even if you changed the original value), you could use the command "Use Original Value" (Germand: "Ursprünglichen Wert benutzen") from the context menu.
      In this case the "New Value" will be set to the "Original Value".

      In 2.4 and 2.4.1 this is not working like expected: It looks like the "New Value" will not be changed. The change is done, but there is no refresh.

          [PICARD-1909] No refresh of metadata on "Use Original Value" or remove tags

          Yep, this is bad It is a side effect of our optimized event handling. Fix is in review.

          Actually this does not only happen on "Use original values", but also on tag removal (via context menu and via hotkey) and when pasting a value into a field (Ctrl+V). So a couple of special cases that where not taken into account when this view got optimized.

          Philipp Wolfer added a comment - Yep, this is bad It is a side effect of our optimized event handling. Fix is in review. Actually this does not only happen on "Use original values", but also on tag removal (via context menu and via hotkey) and when pasting a value into a field (Ctrl+V). So a couple of special cases that where not taken into account when this view got optimized.

          GitHub Bot added a comment -

          See code changes in pull request #1603 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #1603 submitted by phw .

            outsidecontext Philipp Wolfer
            N.A. DELETE ME
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Version Package
                2.4.2