Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2368

Matching files compares "totaltracks" to the total no. of tracks across all mediums on the release

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.8.0rc1
    • 2.6.4, 2.7
    • Lookup & Match
    • None

      When matching file metadata to a track / release Picard compares the "totaltracks" tag of the file to the "track-count" of releases.

      This is wrong for multi-disc releases. "totaltracks" is supposed to hold the total no. of tracks on the medium the track appears on. The "track-count" of a release is the total no. of tracks across all mediums.

      Instead Picard should compare "totaltracks" to the track-count of the matched mediums.

      See PICARD-2360 for more details

          [PICARD-2368] Matching files compares "totaltracks" to the total no. of tracks across all mediums on the release

          Philipp Wolfer added a comment -

          Just to not let my last comment stand there alone, this had been addressed in the final code that got merged for https://github.com/metabrainz/picard/pull/2003

          Philipp Wolfer added a comment - Just to not let my last comment stand there alone, this had been addressed in the final code that got merged for https://github.com/metabrainz/picard/pull/2003

          Philipp Wolfer added a comment -

          The PR is not sufficient. It would regress for clusters, where the file count indeed is the total release count often. That needs to be explicitly handled.

          Philipp Wolfer added a comment - The PR is not sufficient. It would regress for clusters, where the file count indeed is the total release count often. That needs to be explicitly handled.

          GitHub Bot added a comment -

          See code changes in pull request #2003 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #2003 submitted by phw .

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.8.0rc1