Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2421

Consider track MBID when matching files to tracks

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.8.0rc1
    • 2.7.3
    • Lookup & Match
    • None

      Currently when Picard encounters existing relase + recording MBID in file tags it automatically loads the corresponding release and matches the file to the track with matching recording ID.

      This can cause issues on changes to track order as demonstrated on https://community.metabrainz.org/t/picard-confused-when-recordingids-swap-around-in-a-release/572514

      Other cases where this might fail:

      • The recording is no longer linked to any of the tracks
      • The recording appears more than once on the same release (probably really rare, but could happen)

      In some cases it would hence make sense to match by musicbrainz_trackid instead, if present. Hence the proposal:

      • If both musicbrainz_trackid and musicbrainz_recordingid are present in the file, try to match to both the track and recording ID depending on where the file length matches better. On same track length prefer recording ID for improved compatibility with current behavior.
      • If only musicbrainz_recordingid is present in the file, use it for matching
      • If only musicbrainz_trackid is present in the file, use it for matching

            outsidecontext Philipp Wolfer
            outsidecontext Philipp Wolfer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                Version Package
                2.8.0rc1