Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2457

"Search for similar albums" loads cover art into wrong rows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.8.0rc1
    • 2.7.3
    • None
    • None
    • Windows 10

      The results of a search for this Cluster show a mismatch between the Artist and what is shown on the Cover: here a composite showing Scarlatti/Debussy, Chopin/Scarlatti and Schumann/Debussy.

       

        1. image-2022-04-14-02-46-27-859.png
          image-2022-04-14-02-46-27-859.png
          125 kB

          [PICARD-2457] "Search for similar albums" loads cover art into wrong rows

          Philipp Wolfer added a comment -

          Yes, the implementation was just terribly fragile. It relied on row numbers when updating the cover art. So that meant when order changed the cover art could end up in the wrong row. Likewise the row that originally started fetching the cover could end up with the loading animation being stuck, because it never got replaced by the actual cover.

           

          We merged the fix, will be in the 2.8 release

          Philipp Wolfer added a comment - Yes, the implementation was just terribly fragile. It relied on row numbers when updating the cover art. So that meant when order changed the cover art could end up in the wrong row. Likewise the row that originally started fetching the cover could end up with the loading animation being stuck, because it never got replaced by the actual cover.   We merged the fix, will be in the 2.8 release

          Nobulus added a comment -

          That's possible, outsidecontext, (is that the right way to reply here?) if the last row with the eternally spinning 'progress' wheel comes under "while loading is happening".

          Nobulus added a comment - That's possible, outsidecontext , (is that the right way to reply here?) if the last row with the eternally spinning 'progress' wheel comes under "while loading is happening".

          GitHub Bot added a comment -

          See code changes in pull request #2092 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #2092 submitted by phw .

          Philipp Wolfer added a comment -

          Cover art can get mismatched when changing the sorting while loading is happening. I'll submit a fix for this.

          Philipp Wolfer added a comment - Cover art can get mismatched when changing the sorting while loading is happening. I'll submit a fix for this.

          Philipp Wolfer added a comment -

          Thanks for the report. This is pretty odd, it looks like cover art is shifted by one row. Can't reproduce here, though. Need to check the code, maybe I can detect some plausible way how this can happen.

          Philipp Wolfer added a comment - Thanks for the report. This is pretty odd, it looks like cover art is shifted by one row. Can't reproduce here, though. Need to check the code, maybe I can detect some plausible way how this can happen.

            outsidecontext Philipp Wolfer
            Nobulus Nobulus
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Version Package
                2.8.0rc1