Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2508

Scripts being run repeatedly when script editor is open, can result in data duplication for scripts appending to existing tags

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.8.2
    • 2.8.1
    • Scripting
    • None
    • Windows 10 x64
      AMD Ryzen 5800 on ASRock 570x Taichi
      32 GB RAM
      FLAC files to be tagged are accessed from my file server. Error occurs whether I use a mapped drive or an IP address.

      I routinely edit an album title if that album is reissued (the date), remastered, or ripped from an LP.  An edited example: "Dark Side of the Moon (2018 RM LP Rip)"  FYI, RM is my shorthand for remastered.

      Since upgrading to 2.8.1, modifying the %album% tag causes a loop error where the appended text is repeated for each track, often until the character length limit is hit in file naming. In my setup, the bug even affects the documented %_releasecomment% change.

      On a new album to be tagged, the bug is not apparent until I open the file naming editor.  At that point the album tag becomes corrupted with that string of repeats.

      Here's an example of the repeats:

      The Story of a Young Heart (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip) (LP Rip)

      The repeats can be eliminated if I include a second line of script that first checks to see if %album% has already been modded.  If so, it doesn't change the tag.

      This script will cause the repeats:

      $if($eq(%media%,12" Vinyl),$set(album,%album% \(LP Rip\)))

      This one will not:

      $set(_album_extra, \(LP Rip\)) $if($and($eq(%media%,12" Vinyl),$not($in(%album%,%_album_extra%))),$set(album,%album%%_album_extra%))

      For a more detailed discussion, please see my original post.

      Months ago, I updated to Picard 2.7.3, but I immediately reverted back to 2.7.1.  It might have been due to this very issue.  It's been so long, tho, I'm not sure.

      If you need anymore info, please let me know.

        1. ecomaniac debug log.txt
          39 kB
          ecomaniac
        2. ecomaniac scripts.txt
          2 kB
          ecomaniac

            rdswift Bob Swift
            ecomaniac ecomaniac
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:

                Version Package
                2.8.2