Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2866

Non-genre tag added as genre for standalone recording

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 2.12
    • 2.11
    • Tags & Metadata
    • None

      It seems Picard always sets all tags as genre for standalone recordings even when "Use folksonomy tags as genres" is disabled.

      For example, https://musicbrainz.org/recording/c2813cfb-8be5-4d7f-baff-0d9cde2710bc will have "music video" added as genre even though it's not recognized by MusicBrainz as such.

          [PICARD-2866] Non-genre tag added as genre for standalone recording

          I cherry picked this change to the 2.x branch

          Philipp Wolfer added a comment - I cherry picked this change to the 2.x branch

          Zas added a comment -

          chabanplease open another ticket for the search crash, likely another issue

          Zas added a comment - chaban please open another ticket for the search crash, likely another issue

          chaban added a comment -

          👍
          BTW, I think I found another bug. Whenever I search for that recording name from the toolbar and select it from the results Picard immediately crashes. Default config, no hints in debug log

          chaban added a comment - 👍 BTW, I think I found another bug. Whenever I search for that recording name from the toolbar and select it from the results Picard immediately crashes. Default config, no hints in debug log

          Zas added a comment -

          chabanI found the issue, genres weren't clear between refreshes for NonAlbumTrack. Leading to various incorrect behaviors, but I'm pretty sure that's the cause of the issue you reported here. After the fix, changing genres-related options and refreshing the recording works as it should for me.

          Zas added a comment - chaban I found the issue, genres weren't clear between refreshes for NonAlbumTrack. Leading to various incorrect behaviors, but I'm pretty sure that's the cause of the issue you reported here. After the fix, changing genres-related options and refreshing the recording works as it should for me.

          GitHub Bot added a comment -

          See code changes in pull request #2415 submitted by zas.

          GitHub Bot added a comment - See code changes in pull request #2415 submitted by zas .

          Zas added a comment -

          If I have "Use folksonomy tags as genres" disabled, and I load the recording in Picard, Music Video doesn't appear in Genres.
          That's expected.
          Then I totally remove the recording to start fresh.

          If I have "Use folksonomy tags as genres" enabled and I load the recording in Picard, Music Video does appear in Genres.
          That's expected.

          If then I go to Options and disable "Use folksonomy tags as genres" , then just Refresh (via context menu on the already loaded recording) the Music Video tag stays in Genres. This is unexpected (it should not be present after the Refresh).

          chaban Does the Video Music tag appears when starting fresh and not having "Use folksonomy tags as genres" enabled??

          Zas added a comment - If I have "Use folksonomy tags as genres" disabled, and I load the recording in Picard, Music Video doesn't appear in Genres. That's expected. Then I totally remove the recording to start fresh. If I have "Use folksonomy tags as genres" enabled and I load the recording in Picard, Music Video does appear in Genres. That's expected. If then I go to Options and disable "Use folksonomy tags as genres" , then just Refresh (via context menu on the already loaded recording) the Music Video tag stays in Genres. This is unexpected (it should not be present after the Refresh). chaban Does the Video Music tag appears when starting fresh and not having "Use folksonomy tags as genres" enabled??

          chaban added a comment -

          I have disabled it as stated in the ticket's description. Even tried portable build to exclude the possibility of other parts of my configuration messing with it.

          Then tried with a regular recording used in a release. It only happens with standalone recordings so far

          chaban added a comment - I have disabled it as stated in the ticket's description. Even tried portable build to exclude the possibility of other parts of my configuration messing with it. Then tried with a regular recording used in a release. It only happens with standalone recordings so far

          Zas added a comment -

          It is likely because you have "Use folksonomy tags as genres" in Options > Genres enabled.

          See https://picard-docs.musicbrainz.org/en/config/options_genres.html

          Zas added a comment - It is likely because you have "Use folksonomy tags as genres" in Options > Genres enabled. See https://picard-docs.musicbrainz.org/en/config/options_genres.html

            zas Zas
            chaban chaban
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.12