Uploaded image for project: 'Picard'
  1. Picard
  2. PICARD-2939

Crash when loading release with genre filters resulting in empty genre list

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 2.12.1
    • 2.12
    • Lookup & Match
    • Windows 11 Version 23H2

      When attempting to look up release 'Da Drought 2' by Lil Wayne, MusicBrainz Picard crashes every single time. Scanning the files also produces the crash when loading the release. It also crashes when attempting to use the browser script 'Magic tagger button' to add the release in Picard. I have no Picard scripts active.

      https://musicbrainz.org/release/ac51687e-e1fb-4b95-8fed-78e08de11c29

      Update 2024/07/11:

      Second release found that crashed Picard upon loading, lookup, scan, and 'Magic tagger button' from browser, appears to happen when loading the cover: https://musicbrainz.org/release/a3230a8d-daee-4177-9f63-3cf8e2834977

          [PICARD-2939] Crash when loading release with genre filters resulting in empty genre list

          Amazing thank you! Makes sense why it's seemingly random releases!

          Kirsten McEvoy added a comment - Amazing thank you! Makes sense why it's seemingly random releases!

          Thank you so much for the details. With your config I could reproduce the issue and create a fix. The cause  is that your genre filters for these releases lead to an empty genre list. If there are initial genres but the filters filter them all out this is not handled properly in the code.

          We will get a bugfix release 2.12.1 out soon. In the meantime one workaround is to switch back to Picard 2.11 in the meantime, as this issue is new in 2.12. You can get older versions from https://data.musicbrainz.org/pub/musicbrainz/picard/

          Another workaround would be to remove the "-*" from the genre filter and manually check the genre before saving, but this is likely not something you want.

          Philipp Wolfer added a comment - Thank you so much for the details. With your config I could reproduce the issue and create a fix. The cause  is that your genre filters for these releases lead to an empty genre list. If there are initial genres but the filters filter them all out this is not handled properly in the code. We will get a bugfix release 2.12.1 out soon. In the meantime one workaround is to switch back to Picard 2.11 in the meantime, as this issue is new in 2.12. You can get older versions from https://data.musicbrainz.org/pub/musicbrainz/picard/ Another workaround would be to remove the "-*" from the genre filter and manually check the genre before saving, but this is likely not something you want.

          Philipp Wolfer added a comment - Also backported for the 2.x branch  in https://github.com/metabrainz/picard/commit/c8bd90ccb145db46110f70549df3a02b9ba421c5

          GitHub Bot added a comment -

          See code changes in pull request #2523 submitted by phw.

          GitHub Bot added a comment - See code changes in pull request #2523 submitted by phw .

          Files attached, thank you!

          Kirsten McEvoy added a comment - Files attached, thank you!

          Ok, then we need to dig a bit deeper. I cannot reproduce the crashes here, so we need to get some more information from your system to hopefully find the root cause.

          If you could share your Picard config this will hopefully allow me to reproduce the same crash. You can save the Picard.ini file in Options > Advanced > Maintenance. Just be aware that the file can contain your login credentials for MusicBrainz. Either log out of MusicBrainz in Options > General, save the options, then go back to the Maintenance options and export the Picard.ini. Alternatively you can also open the Picard.ini file with a text editor like Notepad and clear all the lines starting with oauth_

          Once you have the file you can attach it here.

           

          If possible it would be also great to get a possible crash log from a command line. If you are using the portable or store version please install Picard using the installer from https://picard.musicbrainz.org/downloads/ first. Then open a Command Prompt from the start menu.

          Inside the command prompt type the following (including the quotation marks):

          "C:\Program Files\MusicBrainz Picard\picard.exe" -d
          

           

          Press enter to start Picard, then load one of the crashing releases to trigger the crash. There will be a lot of output on the command prompt. Please try to copy the output here. If you can't get the whole output at least the very last part when it crashed. With a bit of luck we get some crash info here.

          Philipp Wolfer added a comment - Ok, then we need to dig a bit deeper. I cannot reproduce the crashes here, so we need to get some more information from your system to hopefully find the root cause. If you could share your Picard config this will hopefully allow me to reproduce the same crash. You can save the Picard.ini file in Options > Advanced > Maintenance. Just be aware that the file can contain your login credentials for MusicBrainz. Either log out of MusicBrainz in Options > General, save the options, then go back to the Maintenance options and export the Picard.ini. Alternatively you can also open the Picard.ini file with a text editor like Notepad and clear all the lines starting with oauth_ Once you have the file you can attach it here.   If possible it would be also great to get a possible crash log from a command line. If you are using the portable or store version please install Picard using the installer from https://picard.musicbrainz.org/downloads/ first. Then open a Command Prompt from the start menu. Inside the command prompt type the following (including the quotation marks): "C:\Program Files\MusicBrainz Picard\picard.exe" -d   Press enter to start Picard, then load one of the crashing releases to trigger the crash. There will be a lot of output on the command prompt. Please try to copy the output here. If you can't get the whole output at least the very last part when it crashed. With a bit of luck we get some crash info here.

          I have zero plugins enabled. I have a genres plugin which is not enabled. I do not have the deezerart plugin.

          Kirsten McEvoy added a comment - I have zero plugins enabled. I have a genres plugin which is not enabled. I do not have the deezerart plugin.

          Thanks for the report. What plugins do you have enabled?

          Try disabling any plugins to see if this avoids the crashes. If it does, try enabling the plugins again one by one to see which is responsible for the crashes.

          Specifically check whether you are using the deezerart plugin, which had been the cause for crashes recently. If this is causing the crashes make sure it is updated to the latest version 1.2.1.

          Philipp Wolfer added a comment - Thanks for the report. What plugins do you have enabled? Try disabling any plugins to see if this avoids the crashes. If it does, try enabling the plugins again one by one to see which is responsible for the crashes. Specifically check whether you are using the deezerart plugin, which had been the cause for crashes recently. If this is causing the crashes make sure it is updated to the latest version 1.2.1.

          Added information: these files have been previously tagged via MusicBrainz so this is a new issue (I have changed my naming script and am rerunning my library as I move files to a new HDD).

          Kirsten McEvoy added a comment - Added information: these files have been previously tagged via MusicBrainz so this is a new issue (I have changed my naming script and am rerunning my library as I move files to a new HDD).

            outsidecontext Philipp Wolfer
            fonewearl Kirsten McEvoy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Version Package
                2.12.1